Skip to content

We are in the future, so I removed TODO #510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Aquilae00 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

We are in the future, so I removed TODO #510

Aquilae00 wants to merge 1 commit into from
+0 −1

Conversation

@Aquilae00
Copy link

@Aquilae00 Aquilae00 commented Apr 1, 2023

Technically this is valid

@CLAassistant
Copy link

CLAassistant commented Apr 1, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

wilkerHop
wilkerHop reviewed Apr 1, 2023
View reviewed changes
Copy link

@wilkerHop wilkerHop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jfernandez
Copy link

jfernandez commented Apr 1, 2023

image

Radu-D
Radu-D reviewed Apr 1, 2023
View reviewed changes
Copy link

@Radu-D Radu-D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, GJ!

@steveclifton
Copy link

steveclifton commented Apr 1, 2023

Lgtm!

RangerDevv
RangerDevv reviewed Apr 1, 2023
View reviewed changes
Copy link

@RangerDevv RangerDevv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AMazing!

RodrigoRVSN
RodrigoRVSN reviewed Apr 1, 2023
View reviewed changes
Copy link

@RodrigoRVSN RodrigoRVSN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice pr

fleetimee
fleetimee reviewed Apr 1, 2023
View reviewed changes
Copy link

@fleetimee fleetimee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hunterboppen
hunterboppen reviewed Apr 1, 2023
View reviewed changes
Copy link

@hunterboppen hunterboppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve

pratyakshm
pratyakshm reviewed Apr 4, 2023
View reviewed changes
Copy link

@pratyakshm pratyakshm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

7 more reviewers

@wilkerHop wilkerHop wilkerHop left review comments

@Radu-D Radu-D Radu-D left review comments

@hunterboppen hunterboppen hunterboppen left review comments

@fleetimee fleetimee fleetimee left review comments

@pratyakshm pratyakshm pratyakshm left review comments

@RangerDevv RangerDevv RangerDevv left review comments

@RodrigoRVSN RodrigoRVSN RodrigoRVSN left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.